GHSA-rqf8-2568-r7mc: Manager-with-no-collections can enumerate org user/group → collection mappings (incomplete fix of GHSA-jjxg-p3v6-52ww)
- Published:
- Fetched:
- Updated:
- Affects:
- dani-garcia vaultwarden
https://github.com/dani-garcia/vaultwarden/security/advisories/GHSA-rqf8-2568-r7mc ↗
Manager-with-no-collections can enumerate org user/group → collection mappings (incomplete fix of GHSA-jjxg-p3v6-52ww) ### Summary GHSA-jjxg-p3v6-52ww / CVE-2026-33420 added a per-collection assignment filter to `get_org_collections_details` (and a `has_full_access()` short-circuit to `get_org_collections`) so that a Manager-role member with no collection assignments cannot enumerate the organization's user→collection mapping. The advisory text noted the fix is "consistent with how `get_org_collections` behaves." Two structurally-identical sibling handlers in the same file did NOT receive the equivalent guard. A Manager with `accessAll=false` and no collection assignments can still enumerate: - **BUG #1 — `get_members`** (`src/api/core/organizations.rs:936-963` in 1.36.0): `GET /api/organizations//users?includeCollections=true&includeGroups=true` returns the org-wide per-member collection assignments + per-member group memberships. - **BUG #2 — `get_groups_details`** (`src/api/core/organizations.rs:2445-2448` in 1.36.0): `GET /api/organizations//groups/details` returns each group's collection-permission mapping (group → collection ID + `readOnly` / `hidePasswords` / `manage` flags). Together the pair lets the caller reconstruct the entire org-wide RBAC matrix (who → which collection, via direct grant or group inheritance) — exactly the information the parent CVE was assigned to protect. I'm reporting both as one advisory because they share root cause, remediation pattern, and threat actor. ### Details **PATCHED reference — parent CVE pattern (`get_org_collections` line 386-401):** ```rust #[get("/organizations//collections")] async fn get_org_collections(org_id: OrganizationId, headers: ManagerHeadersLoose, conn: DbConn) -> JsonResult { if org_id != headers.membership.org_uuid { err!("Organization not found", "Organization id's do not match"); } if !headers.membership.has_full_access() { // ← the patch err_code!("Resource not found.", "User does not have full access", rocket::http::Status::NotFound.code); } ... } ``` **UNPATCHED in 1.36.0 — `get_members` (line 936-963):** ```rust #[get("/organizations//users?")] async fn get_members(data: GetOrgUserData, org_id: OrganizationId, headers: ManagerHeadersLoose, conn: DbConn) -> JsonResult { if org_id != headers.membership.org_uuid { err!("Organization not found", "Organization id's do not match"); } let mut users_json = Vec::new(); for u in Membership::find_by_org(&org_id, &conn).await { users_json.push( u.to_json_user_details( data.include_collections.unwrap_or(false), data.include_groups.unwrap_or(false), &conn, ) .await, ); } Ok(Json(json!({"data": users_json, "object": "list", "continuationToken": null}))) } ``` `to_json_user_details(include_collections=true, include_groups=true, ...)` emits per-me Affected packages: rust:vaultwarden Patched: vaultwarden 1.37.0