VulnWatch by ve1ve2
high 7.5 EPSS 0.62%

GHSA-hghq-53p7-c582 / CVE-2026-115578: go-guerrilla crashes on a bare XCLIENT command (7-byte slice off-by-one panic)

Source:
GitHub Security Advisories
Published:
Fetched:
Updated:
Affects:
github.com/phires/go-guerrilla

https://github.com/advisories/GHSA-hghq-53p7-c582 ↗

ghsagoCWE-129CWE-193CWE-248

go-guerrilla crashes on a bare XCLIENT command (7-byte slice off-by-one panic) The defect ---------- Confirmed at HEAD. server.go: cmdXCLIENT = []byte("XCLIENT") is 7 bytes (line 78), so the dispatch match cmdXCLIENT.match(cmd) only guarantees len(input) >= 7. The handler then slices input[8:] (line 586): case sc.XClientOn && cmdXCLIENT.match(cmd): if toks := bytes.Split(input[8:], []byte{' '}); len(toks) > 0 { // line 586 A client sending the bare command XCLIENT (exactly 7 bytes) hits input[8:7] and panics runtime error: slice bounds out of range [8:7]. handleClient runs in the per-connection goroutine (server.go:391) which has no recover(); the only recover() calls are in the backend mail-processing workers (a different goroutine never reached during command parsing), so the unrecovered panic crashes the whole SMTP daemon. Input and attacker ------------------- Connect to the SMTP port, then send XCLIENT\r\n (a bare LF also works; no HELO needed). Precondition: xclient_on: true (off by default, but a documented nginx-fronted deployment; go-guerrilla does not restrict who may send XCLIENT). Attacker model: any unauthenticated client on the SMTP port. Verification level ------------------ EXECUTED with a negative control (agent-run, driving the real server.handleClient with XClientOn=true over the suite's mock net.Conn). The bare XCLIENT panics with the exact OOB; the negative control XCLIENT with a trailing space (8 bytes) does not panic and returns 250. The upstream TestXClient tests XCLIENT ADDR=... and XCLIENT c but never the bare 7-byte form (the missing regression case). I independently re-confirmed at HEAD that cmdXCLIENT is 7 bytes (server.go:78), that the handler slices input[8:] (server.go:586), and that handleClient (server.go:391) has no recover. NOT verified: did not stand up a standalone daemon on a real socket to observe OS-level process exit (used the mock net.Conn plus the traced absence of recover; crash-to-exit is standard Go runtime behavior). Suggested fix ------------- Guard the slice against the exact-verb-length case: require len(input) > len(cmdXCLIENT)+1 (or slice at the verb length and trim) before input[8:]. A recover in the per-connection handleClient loop would also contain any residual command-parse panic to the single connection. Also checked and SOUND ---------------------- The rfc5321 recursive-descent parser (MAIL/RCPT/HELO/EHLO/address) is bounds-safe (next()/peek() return 0 at EOF), and the line/size/recipient caps are enforced. XCLIENT is the only off-by-one; every other command arm slices exactly at its verb length. Advisory-source note -------------------- Five-source enumeration (repo advisories, OSV, NVD, the global GitHub DB, no vendor CNA) shows the PROXY-header IP-spoof bug (CVE-2025-31135, fixed v1.6.7) is the only published advisory; this XCLIENT panic is undisclosed and not contested. Dedup ----- Dedup gate clean: no phires/go-guerrilla blocking verdict in COVERED-INDEX, DISCLOSURE-INDEX or SCOUT-EXCLUDE. Tooling ------- AI assistance was used while inv Affected packages: go:github.com/phires/go-guerrilla Patched: github.com/phires/go-guerrilla 1.6.7-1

Linked vulnerabilities (3)

CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H

go-guerrilla crashes on a bare XCLIENT command (7-byte slice off-by-one panic)

CWE: CWE-129, CWE-193, CWE-248Aliases: CVE-2026-115578, CVE-2025-31135
CVE-2026-115578 high 7.5 EPSS 0.62% (p51) NVDCVE.orgGHSA
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H

go-guerrilla crashes on a bare XCLIENT command (7-byte slice off-by-one panic)

CWE: CWE-129, CWE-193, CWE-248Aliases: GHSA-hghq-53p7-c582, CVE-2025-31135NVD: Received
CVE-2025-31135 medium 5.3 EPSS 0.38% (p33) NVDCVE.org
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:N

Go-Guerrilla SMTP Daemon is a lightweight SMTP server written in Go. Prior to 1.6.7, when ProxyOn is enabled, the PROXY command will be accepted multiple times, with later invocations overriding earlier ones. The proxy protocol only supports one initial PROXY header; anything after that is considered part of the exchange between client and server, so the client is free to send further PROXY commands with whatever data it pleases. go-guerrilla will treat these as coming from the reverse proxy, allowing a client to spoof its IP address. This vulnerability is fixed in 1.6.7.

CWE: CWE-20NVD: Deferred

Also reported by (1)